Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-modern-carousel to SPFx v1.20 & includes other misc changes #5307

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

Sandeep-FED
Copy link
Contributor

@Sandeep-FED Sandeep-FED commented Oct 19, 2024

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This Pull request is for upgrading the sample to latest SPFx version along with few changes in property pane labels, & misc changes related to styles.

Node version used:
v18.18.2

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@Sandeep-FED Sandeep-FED changed the title Upgrade react-modern-carousel SPFx to v1.20 & includes other misc changes Upgrade react-modern-carousel to SPFx v1.20 & includes other misc changes Oct 19, 2024
@hugoabernier hugoabernier merged commit d543655 into pnp:main Oct 21, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Thank you @Sandeep-FED for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants